Adds exponential backoff to MQTT #563

gguuss · 2018-02-08T19:17:54Z

No description provided.

codecov · 2018-02-08T19:28:37Z

Codecov Report

Merging #563 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #563   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           3      3           
=====================================
  Hits            3      3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2523dfc...7a33989. Read the comment docs.

gguuss · 2018-02-15T18:51:54Z

@jmdobry PTAL or I can just merge, I had to refactor a little to keep the tests green.

jmdobry · 2018-02-15T20:41:32Z

iot/mqtt_example/cloudiot_mqtt_example_nodejs.js

@@ -122,18 +137,42 @@ function createJwt (projectId, privateKeyFile, algorithm) {
 // messageCount.
 // [START iot_mqtt_publish]
 function publishAsync (messageCount, numMessages) {


messageCount and numMessages are basically synonymous, which one is used for what? Otherwise LGTM

🤖 I have created a release \*beep\* \*boop\* --- ## [2.4.0](https://www.github.com/googleapis/nodejs-tasks/compare/v2.3.6...v2.4.0) (2021-09-07) ### Features * turns on self-signed JWT feature flag ([#561](https://www.github.com/googleapis/nodejs-tasks/issues/561)) ([9fde4fe](https://www.github.com/googleapis/nodejs-tasks/commit/9fde4fe9a7274493ce0b4bb1a2d25bd85a3e9af2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 408439482 Source-Link: googleapis/googleapis@b9f6184 Source-Link: https://github.com/googleapis/googleapis-gen/commit/eb888bc214efc7bf43bf4634b470254565a659a5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWI4ODhiYzIxNGVmYzdiZjQzYmY0NjM0YjQ3MDI1NDU2NWE2NTlhNSJ9

🤖 I have created a release \*beep\* \*boop\* --- ### [2.5.1](https://www.github.com/googleapis/nodejs-compute/compare/v2.5.0...v2.5.1) (2021-06-10) ### Bug Fixes * flaky test ([#563](https://www.github.com/googleapis/nodejs-compute/issues/563)) ([827a333](https://www.github.com/googleapis/nodejs-compute/commit/827a333443d6716b232fd21e00cc61a4df16aff0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 408439482 Source-Link: googleapis/googleapis@b9f6184 Source-Link: https://github.com/googleapis/googleapis-gen/commit/eb888bc214efc7bf43bf4634b470254565a659a5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWI4ODhiYzIxNGVmYzdiZjQzYmY0NjM0YjQ3MDI1NDU2NWE2NTlhNSJ9

* remove dialogflow_delete_document region tag and code * remove dialogflow_delete_knowledge_base region tag and code * remove dialogflow_detect_intent_with_model_selection region tag and code * remove dialogflow_get_document region tag and code * remove dialogflow_get_knowledge_base region tag and code * remove dialogflow_list_document region tag and code * remove dialogflow_list_knowledge_base region tag and code * remove dialogflow_quickstart code * delete all dialogflow_create* region tags and code * remove dialogflow_delete* region tags and code * remove dialogflow_list* region tags and code * clean up comment span delimiters for deleted code * Update detect.v2beta1.js * Update detect.v2beta1.js * Update resource.js * Update detect.v2beta1.test.js * Update resource.test.js * Update detect.v2beta1.js * docs: remove broken yargs commands from sample deletes * Create create-document.v2beta1.test.js * Create create-intent.test.js * Create create-knowledge-base.v2beta1.test.js * Create create-session-entity-type.test.js * Create delete-intent.test.js * Create delete-session-entity-type.test.js * Update detect.v2beta1.test.js * Create list-session-entity-types.test.js * Update detect.v2beta1.js * Delete resource.test.js Co-authored-by: Your Name <you@example.com> Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com>

🤖 I have created a release \*beep\* \*boop\* --- ## [3.4.0](https://www.github.com/googleapis/nodejs-text-to-speech/compare/v3.3.1...v3.4.0) (2021-12-09) ### Features * adds support for MULAW and ALAW audio encoding ([#565](https://www.github.com/googleapis/nodejs-text-to-speech/issues/565)) ([cf7cb74](https://www.github.com/googleapis/nodejs-text-to-speech/commit/cf7cb74655a5bd1cfc13b670a4b620ac8dd78138)) * update v1beta1 proto ([#562](https://www.github.com/googleapis/nodejs-text-to-speech/issues/562)) ([0d78e6c](https://www.github.com/googleapis/nodejs-text-to-speech/commit/0d78e6c87e51c040c5f35064b53f96d1353f93b9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* remove dialogflow_delete_document region tag and code * remove dialogflow_delete_knowledge_base region tag and code * remove dialogflow_detect_intent_with_model_selection region tag and code * remove dialogflow_get_document region tag and code * remove dialogflow_get_knowledge_base region tag and code * remove dialogflow_list_document region tag and code * remove dialogflow_list_knowledge_base region tag and code * remove dialogflow_quickstart code * delete all dialogflow_create* region tags and code * remove dialogflow_delete* region tags and code * remove dialogflow_list* region tags and code * clean up comment span delimiters for deleted code * Update detect.v2beta1.js * Update detect.v2beta1.js * Update resource.js * Update detect.v2beta1.test.js * Update resource.test.js * Update detect.v2beta1.js * docs: remove broken yargs commands from sample deletes * Create create-document.v2beta1.test.js * Create create-intent.test.js * Create create-knowledge-base.v2beta1.test.js * Create create-session-entity-type.test.js * Create delete-intent.test.js * Create delete-session-entity-type.test.js * Update detect.v2beta1.test.js * Create list-session-entity-types.test.js * Update detect.v2beta1.js * Delete resource.test.js Co-authored-by: Your Name <you@example.com> Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [2.5.1](https://www.github.com/googleapis/nodejs-compute/compare/v2.5.0...v2.5.1) (2021-06-10) ### Bug Fixes * flaky test ([#563](https://www.github.com/googleapis/nodejs-compute/issues/563)) ([827a333](https://www.github.com/googleapis/nodejs-compute/commit/827a333443d6716b232fd21e00cc61a4df16aff0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Adds exponential backoff to MQTT

8139543

Merge branch 'master' into iot-mqtt-backoff

7a9b21e

gguuss self-assigned this Feb 9, 2018

gguuss requested review from jmdobry and ace-n and removed request for ace-n February 9, 2018 20:37

gguuss removed their assignment Feb 9, 2018

Merge branch 'master' into iot-mqtt-backoff

7d1eced

jmdobry approved these changes Feb 15, 2018

View reviewed changes

refactors messageCount to better name

7a33989

gguuss merged commit b61580b into master Feb 15, 2018

gguuss deleted the iot-mqtt-backoff branch February 15, 2018 23:16

grayside mentioned this pull request Oct 26, 2022

migrate code from googleapis/nodejs-tasks #2792

Merged

ace-n mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-automl #2841

Merged

kweinmeister mentioned this pull request Nov 18, 2022

migrate code from googleapis/nodejs-text-to-speech #2872

Merged

ahrarmonsur mentioned this pull request Nov 18, 2022

migrate code from googleapis/nodejs-dialogflow #2873

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds exponential backoff to MQTT #563

Adds exponential backoff to MQTT #563

gguuss commented Feb 8, 2018

codecov bot commented Feb 8, 2018 •

edited

Loading

gguuss commented Feb 15, 2018

jmdobry Feb 15, 2018

gguuss Feb 15, 2018

Adds exponential backoff to MQTT #563

Adds exponential backoff to MQTT #563

Conversation

gguuss commented Feb 8, 2018

codecov bot commented Feb 8, 2018 • edited Loading

Codecov Report

gguuss commented Feb 15, 2018

jmdobry Feb 15, 2018

Choose a reason for hiding this comment

gguuss Feb 15, 2018

Choose a reason for hiding this comment

codecov bot commented Feb 8, 2018 •

edited

Loading